Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace CustomPropTypes.component with PropTypes.elementType #397

Open
aldeed opened this issue Feb 13, 2019 · 0 comments
Open

Replace CustomPropTypes.component with PropTypes.elementType #397

aldeed opened this issue Feb 13, 2019 · 0 comments
Labels
good first issue For issues that a new contributor could likely submit a pull request for without needing much help help wanted For issues that have a clear solution described and are not currently prioritized core team work

Comments

@aldeed
Copy link
Contributor

aldeed commented Feb 13, 2019

Background

We were using our own CustomPropTypes.component prop type until PropTypes had an "anything that can be an element type" validator. As of 15.7.0 release, it now has PropTypes.elementType which is the same as our custom prop type.

https://github.com/facebook/prop-types/blob/master/CHANGELOG.md#1570

Work

  • Update prop-types NPM dependency to 15.7.0 or higher
  • Update all uses of CustomPropTypes.component to PropTypes.elementType
  • Delete CustomPropTypes.component and related code in that file
@aldeed aldeed added help wanted For issues that have a clear solution described and are not currently prioritized core team work good first issue For issues that a new contributor could likely submit a pull request for without needing much help labels Feb 13, 2019
@machikoyasuda machikoyasuda self-assigned this Jun 8, 2019
@machikoyasuda machikoyasuda removed their assignment Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue For issues that a new contributor could likely submit a pull request for without needing much help help wanted For issues that have a clear solution described and are not currently prioritized core team work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aldeed @machikoyasuda