deleted extraneous commented out code #480
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nick gill <nick.gilliosipescu@gmail.com>
|
🚀 Preview deployed Built with commit 42da25a https://deploy-preview-480--stoic-hodgkin-c0179e.netlify.com |
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the
best of my knowledge, is covered under an appropriate open
source license and I have the right under that license to
submit that work with modifications, whether created in whole
or in part by me, under the same open source license (unless
I am permitted to submit under a different license), as
Indicated in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including
all personal information I submit with it, including my
sign-off) is maintained indefinitely and may be redistributed
consistent with this project or the open source license(s)
involved.
Signed-off-by: nick gill <nick.gilliosipescu@gmail.com>
aldeed
requested changes
May 4, 2020
There was a problem hiding this comment.
@gizmoGremlin To pass DCO check, you need to use --signoff option on every git commit in your branch. If you check out this branch and run the following, I think that should fix this PR:
git reset --soft HEAD~5
git commit --signoff -m "chore: delete extra comment in Address.js"
git push --force
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #477
Impact: minor
Type: chore
Component
Description of the issue this component this PR adds. Also include, as necessary:
Screenshots
Include mobile and desktop screenshots.
Breaking changes
You should almost never include "BREAKING CHANGES" because we’re duplicating components to avoid that. Consult with others before doing it.
Testing
More detail for what each of these sections should include are available in our Contributing Docs