docs: add mjs config details to installation docs #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
|
🚀 Preview deployed Built with commit 67a975c https://deploy-preview-402--stoic-hodgkin-c0179e.netlify.com |
machikoyasuda
suggested changes
Mar 1, 2019
|
|
||
| Webpack 4 tries to use .mjs files, which are EcmaScript modules, if a package provides them. However, there is still mixed support for EcmaScript modules and when your app or a package mixes NPM packages with CommonJS and EcmaScript exports, errors can happen. If you see an error similar to `Can't import the named export 'Component' from non EcmaScript module` when building or starting your Webpack app, the solution is to add the following in your Webpack config `module.rules` array: | ||
|
|
||
| ```js |
There was a problem hiding this comment.
React Styleguidist will try to render any ```js code. So it ends up looking like this:
Use jsx static or jsx noeditor so the editor doesn't show up: https://react-styleguidist.js.org/docs/documenting.html#usage-examples-and-readme-files
There was a problem hiding this comment.
Thanks I forgot about this
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
machikoyasuda
approved these changes
Mar 1, 2019
|
🎉 This PR is included in version 0.64.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
I have and issue when I run npm start I get this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #399
Impact: minor
Type: docs
Updated the Installing and Importing article to explain how to avoid EcmaScript module errors with Webpack (NextJS / create-react-app).