Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details explaining changes to from roles to Groups #299

Closed
impactmass opened this issue Oct 17, 2017 · 2 comments
Closed

Add details explaining changes to from roles to Groups #299

impactmass opened this issue Oct 17, 2017 · 2 comments

Comments

@impactmass
Copy link
Contributor

Things around the fact that:

The previous shop.defaultVisitorRoles are the roles now defined in the guest group.
Also, the previous shop.defaultCustomerRoles are the roles now defined in the default customer group.

So a previous reference to shop.defaultVisitorRoles should now use the group object (e.g Groups.find({slug: "guest"}).permissions).

The default list of those roles that we had on the Shop schema are present on server export of Reaction (i.e Reaction.default...)

Ref: reactioncommerce/reaction#2183

@machikoyasuda
Copy link
Contributor

Closed w/ #311

@impactmass
Copy link
Contributor Author

Hi @machikoyasuda .. #311 did not actually cover everything for this ticket. I could have combined then but didn't think about it. I can get this in soon too (should not be more than a few sentences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants