Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Developer]: Create "code-reviewer" doc with a checklist of items to check for #450

Closed
brent-hoover opened this issue Jan 27, 2018 · 1 comment
Closed

[Developer]: Create "code-reviewer" doc with a checklist of items to check for #450

brent-hoover opened this issue Jan 27, 2018 · 1 comment
Assignees
@brent-hoover

Comments

@brent-hoover
Copy link
Collaborator

Guidelines for doing Code review

Common thing to look for such as:

  1. Security
  2. Performance
  3. Consistency
@brent-hoover brent-hoover self-assigned this Jan 27, 2018
@machikoyasuda machikoyasuda changed the title Create "code-reviewer" doc with a checklist of items to check for [Developer]: Create "code-reviewer" doc with a checklist of items to check for Feb 1, 2018
@machikoyasuda machikoyasuda mentioned this issue Feb 2, 2018
Merged
@machikoyasuda
Copy link
Contributor

Closed w/ #465

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brent-hoover brent-hoover

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brent-hoover @machikoyasuda