Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.8 - Rename Media to BrandAssets #490

Closed
machikoyasuda opened this issue Feb 14, 2018 · 3 comments
Closed

Release 1.8 - Rename Media to BrandAssets #490

machikoyasuda opened this issue Feb 14, 2018 · 3 comments
Assignees
@machikoyasuda

Comments

@machikoyasuda
Copy link
Contributor

Update https://docs.reactioncommerce.com/reaction-docs/master/image-handling to reflect changes upcoming in Release 1.8 reactioncommerce/reaction#3558
This was referenced Feb 14, 2018
Merged
Merged
@prinzdezibel
Copy link
Contributor

@machikoyasuda I don't think we need changes to that document. The collection is still called Media,
because it still contains all images, not only the brand asset. The subscription name for retrieving the brand assets has changed though, but those subscription name is not referenced in the URL.

@prinzdezibel
Copy link
Contributor

If you agree, please close. Or let me know if I got something wrong. thanks.

@machikoyasuda
Copy link
Contributor Author

@prinzdezibel Got it! Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@machikoyasuda machikoyasuda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prinzdezibel @machikoyasuda