Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email settings in ENV vars override those in dashboard #1442

Closed
mikemurray opened this issue Sep 26, 2016 · 2 comments
Closed

Email settings in ENV vars override those in dashboard #1442

mikemurray opened this issue Sep 26, 2016 · 2 comments

Comments

@mikemurray
Copy link
Member

mikemurray commented Sep 26, 2016

Expected behavior

If credentials from ENV vars will override the mail settings in the dashboard, then they should be displayed in the dashboard.

Actual Behavior

  • Credentials from ENV override settings in dashboard, but the dashboard does not reflect that.

Steps to Reproduce the Behavior

  • Export bad mail settings
  • Reset and run reaction
  • See errors in terminal when emails fail to send
export MAIL_URL="smtp://postmaster%40sandboxXXXX.mailgun.org:BAD_PASSWORD@smtp.mailgun.org:587"
@rstegg
Copy link

rstegg commented Dec 21, 2016

And email form should probably be more consistent, keeping API Key and credentials [as an option or dully marked not all inputs are always necessary]. For example, send grid can use API key or user credentials.

@brent-hoover brent-hoover modified the milestone: v1.2.x Apr 18, 2017
@aaronjudd aaronjudd added bug For issues that describe a defect or regression in the released software enhancement and removed bug For issues that describe a defect or regression in the released software enhancement labels Apr 27, 2017
@aaronjudd
Copy link
Contributor

Closing - insufficient details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants