Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when reordering variants #2004

Closed
dshitik opened this issue Mar 16, 2017 · 7 comments
Closed

Error when reordering variants #2004

dshitik opened this issue Mar 16, 2017 · 7 comments
Assignees
Labels
bug For issues that describe a defect or regression in the released software
Milestone

Comments

@dshitik
Copy link

dshitik commented Mar 16, 2017

Look. When I change the location of product variants in the product card and press the "publish" button, I get the following error:
Exception in delivering result of invoking 'revisions / publish': TypeError: Can not read property 'handle' of undefined

Version of product - v.1
2017-03-16 11-38-59

@brent-hoover
Copy link
Collaborator

@dshitik Can you provide some replication instructions so we can properly try to debug this?

@dshitik
Copy link
Author

dshitik commented Mar 16, 2017

  1. I create 2 or more variants in the card product.
  2. Swap variants.
  3. I click the "publish" button.
    The following occurs:
    A notification appears that the data has been saved, but it gives the above error.
    In the correction to the previous message - all the same, I can change the data and publish the individual options and if I click the "publish" button, the data will be correctly saved to the database. However, this error only applies to the user interface, it does not display up-to-date information about which options are published.
    To see the changes in the user interface regarding the publication of product variants, I need to reload the page.

@dshitik
Copy link
Author

dshitik commented Mar 16, 2017

And just want to say that when moving options from place to place and then press the button "publish", icons with pencils remain yellow. Total: it is necessary to correct ui.

@brent-hoover
Copy link
Collaborator

@dshitik Can you explain what you mean when you say "swap variants"?

@dshitik
Copy link
Author

dshitik commented Mar 16, 2017

I explain, moving variants of product from place to place. Sorry for my english.

@brent-hoover brent-hoover changed the title Error with variants product. Error with when reordering variants Mar 20, 2017
@brent-hoover
Copy link
Collaborator

I have verified I get this when I add a variant and then reorder.

Steps to reproduce

  1. reaction reset
  2. Navigate to the PDP
  3. Add a couple more variants
  4. Publish
  5. Reorder variants
  6. Publish
  7. Observe error

@brent-hoover brent-hoover changed the title Error with when reordering variants Error when reordering variants Mar 20, 2017
@brent-hoover brent-hoover added bug For issues that describe a defect or regression in the released software ready labels Mar 21, 2017
@brent-hoover brent-hoover self-assigned this Mar 23, 2017
@brent-hoover brent-hoover added this to the v1.0.x milestone Mar 23, 2017
@brent-hoover
Copy link
Collaborator

Closed via PR #2033

@ghost ghost removed the in progress label Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For issues that describe a defect or regression in the released software
Projects
None yet
Development

No branches or pull requests

2 participants