Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Marketplace] New permissions added to an existing RC app should update existing users permissions appropriately #2195

Closed
spencern opened this issue May 1, 2017 · 3 comments
Assignees

Comments

@spencern
Copy link
Contributor

spencern commented May 1, 2017

When new permissions are added to existing permission groups (e.g. through the registry), existing users should have their permissions updated appropriately.

This could possibly be accomplished by checking and updating a permission group for authorization rather than that each user has a specific permission if the user is in a specific group.

Currently when new permissions are added to defaultRoles existing users are not granted those permissions.

@spencern spencern added this to the Marketplace Permissions milestone May 1, 2017
@spencern spencern changed the title New permissions added to an existing RC app should update existing users permissions appropriately [Marketplace] New permissions added to an existing RC app should update existing users permissions appropriately May 1, 2017
@spencern
Copy link
Contributor Author

@impactmass - I think this is partially completed by your groups PR as changing the permissions in the dashboard will update all users with that group, correct?

What is not completed here is if you use the addRolesToGroups method I don't think that checks existing users.

@impactmass
Copy link
Contributor

Yes. Changing it in the dashboard updates the users. The pending part is addRolesToGroups.

@spencern
Copy link
Contributor Author

Closed by #2606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants