Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMS Notifications not sent. #2485

Closed
michael-alade opened this issue Jun 21, 2017 · 1 comment
Closed

SMS Notifications not sent. #2485

michael-alade opened this issue Jun 21, 2017 · 1 comment
Assignees
Labels
bug For issues that describe a defect or regression in the released software

Comments

@michael-alade
Copy link

Expected behavior

SMS should be sent after an order event is fired.

Actual Behavior

Currently, Twilio has updated their library of which the API documentation is different from the previous one. This is now causing the SMS not be sent.

Steps to Reproduce the Behavior

  • Login as admin
  • Go the SMS notification settings
  • Choose an SMS Provider and account credentials
  • Sign up as a new user and make an order
  • After the order is completed, the SMS is not sent.

Versions

Node: 6.10.0
NPM: 3.10.10
Reaction CLI: 0.8.0
Reaction: 1.3.0
Reaction Branch: updated-packages-1.3.1

Approach for testing
The sms/send meteor method should be tested to ensure that the SMS notifications are sent. The SMS library callback result should be returned.

@aaronjudd aaronjudd added the bug For issues that describe a defect or regression in the released software label Jun 22, 2017
@desaawa desaawa self-assigned this Jun 28, 2017
@brent-hoover
Copy link
Collaborator

Closed via #2508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For issues that describe a defect or regression in the released software
Projects
None yet
Development

No branches or pull requests

4 participants