Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and cleanup of i18n. #3009

Closed
spencern opened this issue Oct 3, 2017 · 0 comments
Closed

Refactor and cleanup of i18n. #3009

spencern opened this issue Oct 3, 2017 · 0 comments
Labels
chore For issues that describe a task that does not affect the release, such as tests or CI configuration

Comments

@spencern
Copy link
Contributor

spencern commented Oct 3, 2017 •
edited
Loading

i18n issues keep coming up. For now when you see an i18n blocker, please reference this PR, and once we're ready to release 1.5.0, someone can go through and fix all the i18n issues in one go rather than having these things keep coming up as blockers that get fixed piecemeal.

#1593
#1689
#2983

Additionally this issue should cover:

  • refactoring existing i18n files to use sentence casing
  • Migrating i18n definitions out of /private/data/i18n/ and into the appropriate plugin i18n file.
  • Definitions that are not specific to a plugin should live in /imports/plugins/core/i18n
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore For issues that describe a task that does not affect the release, such as tests or CI configuration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brent-hoover @aaronjudd @spencern @aldeed