Dashboard panel keeps re-opening during checkout #2010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brent-hoover
approved these changes
Mar 19, 2017
mikemurray
reviewed
Mar 22, 2017
There was a problem hiding this comment.
Does't seem to work for me.
I have shipping enabled and configured, but the shipping panel keeps opening up every time I go to the checkout page, and when I delete / re-add address.
- Did a full reset and everything.
- Im only using flat rate shipping with the first 2 shipping methods enabled.
|
Ok. I'll go over this again to spot what could be going on. |
|
OK.... Found the issue... So. this branch But that update is affecting what I've done in this PR, causing @mikemurray to get unexpected results. I'll do a rebase for this branch. |
|
This is good for a second pass @mikemurray |
jshimko
added a commit
to evereveofficial/reaction
that referenced
this pull request
Mar 27, 2017
* development: fix elasticsearch errors skip npm install outside of container on CI wait longer on CI for Docker test update CI config for Evereve add ReactionPublicCustomFolder update data_import update data_import update data_import add submodules to circle config add plugin submodules Don't reload when the main product is not in tbe modified products (reactioncommerce#2033) If default provider is not available, then add it. (reactioncommerce#2025) Dashboard panel keeps re-opening during checkout (reactioncommerce#2010) fixing issue 2008 getting 404 error on variant option (reactioncommerce#2021) Create "Tax Detail" view in Orders Dashboard (reactioncommerce#2005)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1953.
Change made: Use proper check for enable shipping on sidebar display
How to test:
reaction resetbefore starting the app.You can do multiple variations of trying to checkout with shipping configured and when it is not.