If default provider is not available, then add it. #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
impactmass
approved these changes
Mar 23, 2017
jshimko
added a commit
to evereveofficial/reaction
that referenced
this pull request
Mar 27, 2017
* development: fix elasticsearch errors skip npm install outside of container on CI wait longer on CI for Docker test update CI config for Evereve add ReactionPublicCustomFolder update data_import update data_import update data_import add submodules to circle config add plugin submodules Don't reload when the main product is not in tbe modified products (reactioncommerce#2033) If default provider is not available, then add it. (reactioncommerce#2025) Dashboard panel keeps re-opening during checkout (reactioncommerce#2010) fixing issue 2008 getting 404 error on variant option (reactioncommerce#2021) Create "Tax Detail" view in Orders Dashboard (reactioncommerce#2005)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2018
I decided on this method although I think it could be equally valid to say "you need to import the default method if you are going to modify them". Also maybe there is a better way to change that validation so you can still use the
ShippingMethodschema?How to test:
Shipping.jsonreaction reset && reaction