Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Delete Product Tooltip To Archive Product #2030

Merged
merged 7 commits into from
Mar 28, 2017
Merged

Change Delete Product Tooltip To Archive Product #2030

merged 7 commits into from
Mar 28, 2017

Conversation

michael-alade
Copy link

@michael-alade michael-alade commented Mar 22, 2017 •
edited
Loading

Resolves
#2014

Manual Test

  • Login as admin
  • Click on a product
  • Hover for 3 seconds on the archive icon on the selected panel header by the right part of your screen
  • The tooltip should show Archive product.
  • Also, click on the product to view the details.
  • Click the pencil icon on a variant to view the details.
  • On the panel header you would see an archive icon, with a tooltip saying Archive Variant
  • You can also click a variant option to view its details.
  • Below the edit form, you would see an archive icon with a tooltip saying Archive Option

brent-hoover
brent-hoover requested changes Mar 22, 2017
View reviewed changes
Copy link
Collaborator

@brent-hoover brent-hoover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the Trashcan is the best icon for "Archive". Don't we use a different icon elsewhere for "Archive"?

Also we still have "Remove Variant" which is also just Archiving that we should also probably change. (and maybe should be "Remove Option"?)

server/methods/catalog.js Outdated
@@ -700,12 +700,12 @@ Meteor.methods({
},

/**
* products/deleteProduct
* products/archiveProduct
* @summary delete a product and unlink it from all media
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should change this in the comment as well

private/data/i18n/en.json Outdated
@@ -255,7 +255,7 @@
"duplicateProduct": "Duplicate Product",
"pinProduct": "Pin Product",
"toggleSize": "Toggle Size",
"deleteProduct": "Delete Product",
"archiveProduct": "Archive Product",
"restoreProduct": "Restore Product from Trash",
"deleteSelectedProducts": "Delete selected products?",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this "Delete selected products?"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we do not.

@brent-hoover
Copy link
Collaborator

Let's change the icon there to be fa-archive

@brent-hoover
Copy link
Collaborator

Still seeing the trashcan here and here
basic_reaction_product

basic_reaction_product

@brent-hoover brent-hoover merged commit 4ff1276 into development Mar 28, 2017
@brent-hoover brent-hoover deleted the michael-archive-product-tooltip-2014 branch March 28, 2017 02:25
@brent-hoover brent-hoover changed the title [WIP] 2014 Change Delete Product Tooltip To Archive Product Change Delete Product Tooltip To Archive Product Mar 28, 2017
@brent-hoover brent-hoover mentioned this pull request Mar 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brent-hoover brent-hoover brent-hoover approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michael-alade @brent-hoover