Added a not found view to product grid #2656
Conversation
mikemurray
commented
Aug 8, 2017
mikemurray
commented
- Added new component NotFound that lets you do blank views
- Added not found view to product grid if tag was not found
- Added new component NotFound that lets you do blank views - Added not found view to product grid if tag was not found
mikemurray
changed the title
|
@mikemurray If I go to a non-existent tag I don't get a 404 I get a "No Products Found". Is that the correct behavior? |
|
Is it my imagination or does rendering of products now seem considerably slower? |
|
If I go to a tag with no products I just get nothing rather than the "No Products Found" page. |
|
I think I only did, The load may be slower / feel slower. |
|
I feel like if I go to a tag with no products I should get the "No product" message rather than just a blank page which looks broken. What do you think? That's the way it currently works on |
|
I agree, would be easy to add I think. |
| }, props.className); | ||
|
|
||
| // ClassName for content wrapper | ||
| // If one is provied in props, the default is not used |
|
|
||
| /** | ||
| * Baase wrapper className | ||
| * @summary String className of `classnames` compatable object for the base wrapper |
| NotFound.propTypes = { | ||
| /** | ||
| * Children | ||
| * @type {ReactNode} |
There was a problem hiding this comment.
Should we make this more consistent? I feel like we call this different things different place (e.g. Node/ReactNode/JSX. Is there a difference?)
There was a problem hiding this comment.
Maybe just go with Node prop type.
@machikoyasuda what do you think? Maybe we can set up a type in jsdoc that knows Node is react node when the docs are generated?
| children: PropTypes.node, | ||
|
|
||
| /** | ||
| * Baase wrapper className |
|
|
||
| /** | ||
| * Content className | ||
| * @summary String className of `classnames` compatable object for the content wrapper |
There was a problem hiding this comment.
typo in comment (compatible)
- Adds jsdoc to all members of Products class
|
@zenweasel Should now show the not-found view if the tag is valid, but no products were found still. @machikoyasuda As a bonus, jsdoc'd all the things in |
|
|
||
| /** | ||
| * Base wrapper className | ||
| * @summary String className or `classnames` compatable object for the base wrapper |
There was a problem hiding this comment.
compatible still spelled wrong isn't it?
|
@mikemurray three lint errors that seem to come from nowhere |
|
@zenweasel wonder if something changed in our eslint config since those files were passing before, right? |
The classnames transformation for FlatButton icons was unnecessary.
|
Fixed all lint issues |
|
@mikemurray yeah, I don't know where those lint errors came from but thanks for fixing them |
|
@mikemurray @machikoyasuda still two lint errors left |
|
ok, whats going on. I fixed all the lint errors and more keep popping up? |
|
All green! |
