-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Order data fetch #2972
Order data fetch #2972
Conversation
selectAllOrders={this.selectAllOrders} | ||
multipleSelect={this.state.multipleSelect} | ||
setShippingStatus={this.setShippingStatus} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this space here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kieckhafer fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes made to translations, looks good to go.
Resolves #2837 #2952 #2768
TEST #2837
Expected behavior
When there's a filter applied to the orders table and
select all
action performed, only the filtered orders should be selected.Actual Behavior
Even with a filter applied,
select all
selects all orders present in the table.How to test
TEST #2952
Expected behavior
Orders table should have the same number of rows as orders.
For example: If there are two orders, have just two rows displayed.
Actual Behavior
Extra empty rows appear even when there are orders.
How to test
TEST #2768
Problem
Order Dashboard Table was using ReactTable's way of passing publication/collection as opposed to passing it the actual data
How to test