From 3b7a84665abc1475c82eacc383727ebf2e148725 Mon Sep 17 00:00:00 2001 From: Erik Kieckhafer Date: Tue, 13 Feb 2018 11:33:03 -0800 Subject: [PATCH 1/5] fix positioning of remove item icon --- .../included/default-theme/client/styles/cart/cartItems.less | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/imports/plugins/included/default-theme/client/styles/cart/cartItems.less b/imports/plugins/included/default-theme/client/styles/cart/cartItems.less index 8f308d58517..d0d7aa9f991 100644 --- a/imports/plugins/included/default-theme/client/styles/cart/cartItems.less +++ b/imports/plugins/included/default-theme/client/styles/cart/cartItems.less @@ -30,8 +30,8 @@ .remove-cart-item { position: absolute; - top: 8px; - .right(8px); + top: -8px; + .right(-8px); color: @gray; background-color: @alert-warning-bg; border: 2px solid @gray; From 367dfd1e7aa8aaedc6b762eea18ce6c433050bd4 Mon Sep 17 00:00:00 2001 From: Erik Kieckhafer Date: Tue, 13 Feb 2018 15:04:31 -0800 Subject: [PATCH 2/5] ref: add css for aria icon-button --- .../plugins/core/checkout/client/components/cartItems.js | 1 + .../core/ui/client/components/button/iconButton.js | 6 ++++++ .../default-theme/client/styles/cart/cartItems.less | 8 +++++++- 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/imports/plugins/core/checkout/client/components/cartItems.js b/imports/plugins/core/checkout/client/components/cartItems.js index f64851f7e8e..087dcba1a3e 100644 --- a/imports/plugins/core/checkout/client/components/cartItems.js +++ b/imports/plugins/core/checkout/client/components/cartItems.js @@ -50,6 +50,7 @@ class CartItems extends Component { { "icon-only": true, "status-badge": true }); + } else if (otherProps.kind === "removeItem") { + buttonClassName = classnames({ + "icon-only": true, + "variant-edit": true, + "remove-item-aria-container": true + }); } else { buttonClassName = classnames({ "icon-only": true, diff --git a/imports/plugins/included/default-theme/client/styles/cart/cartItems.less b/imports/plugins/included/default-theme/client/styles/cart/cartItems.less index d0d7aa9f991..cc399f898de 100644 --- a/imports/plugins/included/default-theme/client/styles/cart/cartItems.less +++ b/imports/plugins/included/default-theme/client/styles/cart/cartItems.less @@ -28,10 +28,16 @@ white-space: pre-wrap; } - .remove-cart-item { + .remove-item-aria-container { position: absolute; top: -8px; .right(-8px); + } + + .remove-cart-item { + position: absolute; + top: 0px; + .right(0px); color: @gray; background-color: @alert-warning-bg; border: 2px solid @gray; From e32347ff91ce2499845b877274bad555db146c3a Mon Sep 17 00:00:00 2001 From: Erik Kieckhafer Date: Tue, 13 Feb 2018 15:14:48 -0800 Subject: [PATCH 3/5] ref: update icon style --- .../included/default-theme/client/styles/cart/cartItems.less | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/imports/plugins/included/default-theme/client/styles/cart/cartItems.less b/imports/plugins/included/default-theme/client/styles/cart/cartItems.less index cc399f898de..de12f99d085 100644 --- a/imports/plugins/included/default-theme/client/styles/cart/cartItems.less +++ b/imports/plugins/included/default-theme/client/styles/cart/cartItems.less @@ -39,8 +39,7 @@ top: 0px; .right(0px); color: @gray; - background-color: @alert-warning-bg; - border: 2px solid @gray; + border: 1px solid @gray; padding: 5px; border-radius: 50%; z-index: 99; From 7ff6e5c58e2c3dc6f7b720b6a4f302026feb786b Mon Sep 17 00:00:00 2001 From: Erik Kieckhafer Date: Tue, 13 Feb 2018 16:27:41 -0800 Subject: [PATCH 4/5] ref: remove border on icon --- .../included/default-theme/client/styles/cart/cartItems.less | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/imports/plugins/included/default-theme/client/styles/cart/cartItems.less b/imports/plugins/included/default-theme/client/styles/cart/cartItems.less index de12f99d085..42e2c9778d3 100644 --- a/imports/plugins/included/default-theme/client/styles/cart/cartItems.less +++ b/imports/plugins/included/default-theme/client/styles/cart/cartItems.less @@ -39,7 +39,7 @@ top: 0px; .right(0px); color: @gray; - border: 1px solid @gray; + background-color: @alert-warning-bg; padding: 5px; border-radius: 50%; z-index: 99; From 4255f5c8c8589f9d24178a944d686b602e630edf Mon Sep 17 00:00:00 2001 From: Erik Kieckhafer Date: Tue, 13 Feb 2018 16:43:14 -0800 Subject: [PATCH 5/5] update background color --- .../included/default-theme/client/styles/cart/cartItems.less | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/imports/plugins/included/default-theme/client/styles/cart/cartItems.less b/imports/plugins/included/default-theme/client/styles/cart/cartItems.less index 42e2c9778d3..83e695c59d8 100644 --- a/imports/plugins/included/default-theme/client/styles/cart/cartItems.less +++ b/imports/plugins/included/default-theme/client/styles/cart/cartItems.less @@ -39,7 +39,7 @@ top: 0px; .right(0px); color: @gray; - background-color: @alert-warning-bg; + background-color: @black15; padding: 5px; border-radius: 50%; z-index: 99;