Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emitting afterAddTagsToProducts, afterTagDelete, afterRemoveTagsFromProducts #6541

Merged
merged 9 commits into from
Oct 7, 2022
Merged

Emitting afterAddTagsToProducts, afterTagDelete, afterRemoveTagsFromProducts #6541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
893dd96
feat: Emitting afterAddTagsToProducts, afterTagDelete, afterRemoveTag…
vishalmalu Oct 3, 2022
992d473
fix: Fixed eslint errors
vishalmalu Oct 3, 2022
a1f6320
Merge branch 'trunk' into feature/additional-tag-product-events
vishalmalu Oct 3, 2022
479bcc3
fix: Fixed eslint errors
vishalmalu Oct 3, 2022
bd59efe
Merge branch 'feature/additional-tag-product-events' of https://githu…
vishalmalu Oct 3, 2022
de7cd55
fix: Fixed eslint errors
vishalmalu Oct 3, 2022
6f0143d
chore: added changeset
vishalmalu Oct 4, 2022
7092157
fix: review comments, moved appEvents declaration
vishalmalu Oct 4, 2022
fa4763e
fix: review comments, moved appEvents declaration
vishalmalu Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/beige-doors-poke.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@reactioncommerce/api-plugin-products": minor
"@reactioncommerce/api-plugin-tags": minor
---

Added afterAddTagsToProducts, afterTagDelete, afterRemoveTagsFromProducts events when respective mutations are called.
4 changes: 3 additions & 1 deletion packages/api-plugin-products/src/mutations/addTagsToProducts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import executeBulkOperation from "../utils/executeBulkOperation.js";
*/
export default async function addTagsToProducts(context, input) {
const { productIds, shopId, tagIds } = input;
const { collections: { Products } } = context;
const { appEvents, collections: { Products } } = context;
const totalProducts = productIds.length;

for (const _id of productIds) {
Expand All @@ -39,5 +39,7 @@ export default async function addTagsToProducts(context, input) {

const results = await executeBulkOperation(Products, operations, totalProducts);

await Promise.all(tagIds.map((tagId) => appEvents.emit("afterAddTagsToProducts", { tagId, productIds })));

return results;
}
4 changes: 3 additions & 1 deletion packages/api-plugin-products/src/mutations/removeTagsFromProducts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import executeBulkOperation from "../utils/executeBulkOperation.js";
*/
export default async function removeTagsFromProducts(context, input) {
const { productIds, shopId, tagIds } = input;
const { collections: { Products } } = context;
const { appEvents, collections: { Products } } = context;
const totalProducts = productIds.length;

for (const _id of productIds) {
Expand All @@ -40,5 +40,7 @@ export default async function removeTagsFromProducts(context, input) {

const results = await executeBulkOperation(Products, operations, totalProducts);

await Promise.all(tagIds.map((tagId) => appEvents.emit("afterRemoveTagsFromProducts", { tagId, productIds })));

return results;
}
4 changes: 3 additions & 1 deletion packages/api-plugin-tags/src/mutations/removeTag.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import ReactionError from "@reactioncommerce/reaction-error";
*/
export default async function removeTag(context, input) {
const { shopId, tagId } = input;
const { Tags } = context.collections;
const { appEvents, collections: { Tags } } = context;

await context.validatePermissions(`reaction:legacy:tags:${tagId}`, "delete", { shopId });

Expand All @@ -22,5 +22,7 @@ export default async function removeTag(context, input) {
throw new ReactionError("not-found", "Tag not found");
}

await appEvents.emit("afterTagDelete", tag);

return tag;
}