Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use YJS for sending diffs (JsonPatch replacement) #826

Open
rmorshea opened this issue Oct 20, 2022 · 0 comments
Open

Use YJS for sending diffs (JsonPatch replacement) #826

rmorshea opened this issue Oct 20, 2022 · 0 comments
Labels
priority-3-low May be resolved one any timeline. release-patch Warrents a patch release type-revision About a change in functionality or behavior

Comments

@rmorshea
Copy link
Collaborator

rmorshea commented Oct 20, 2022 •
edited
Loading

Current Situation

Currently, we've effectively turned off diffing with JsonPatch due to bugs in the Python implementation.

Proposed Actions

While what we're doing now seems to work fine. We could replace JsonPatch with YJS since the YJS protocol has a Python implementation and an ASGI compliant websocket connector. Since the Python implementation ultimately wraps a Rust binary, this would likely be many times faster than JsonPatch, being implemented in pure Python, ever could have been.
@rmorshea rmorshea added the priority-3-low May be resolved one any timeline. label Oct 20, 2022
@rmorshea rmorshea added this to the 2.0 milestone Oct 20, 2022
@rmorshea rmorshea mentioned this issue Oct 22, 2022
Closed
@rmorshea rmorshea removed this from the Luxury milestone Feb 21, 2023
@rmorshea rmorshea added type-revision About a change in functionality or behavior release-major Warrents a major release release-patch Warrents a patch release and removed release-major Warrents a major release labels Apr 27, 2023
@rmorshea rmorshea mentioned this issue Apr 30, 2023
Open
@rmorshea rmorshea changed the title Replace JsonPatch with YJS Use YJS to send view changes Jun 22, 2023
@Archmonger Archmonger changed the title Use YJS to send view changes Use YJS for sending diffs (JsonPatch replacement) Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority-3-low May be resolved one any timeline. release-patch Warrents a patch release type-revision About a change in functionality or behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rmorshea