Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Back Pre-Commit Hooks #925

Closed
Archmonger opened this issue Feb 13, 2023 · 0 comments · Fixed by #1024
Closed

Add Back Pre-Commit Hooks #925

Archmonger opened this issue Feb 13, 2023 · 0 comments · Fixed by #1024
Labels
flag-good-first-issue A well defined and self-contained task. priority-3-low May be resolved one any timeline. type-ci About change and updates to the Continuous Integration

Comments

@Archmonger
Copy link
Contributor

Archmonger commented Feb 13, 2023 •
edited by rmorshea
Loading

Current Situation

After repo was re-organized pre-commit was removed just to get that in quicker. We should add back pre-commit hooks.

Proposed Actions

Add pre-commit hooks that match linting that happens in CI:

  • black
  • Ruff
  • mypy
@Archmonger Archmonger added the type-ci About change and updates to the Continuous Integration label Feb 13, 2023
@Archmonger Archmonger added this to the Luxury milestone Feb 13, 2023
@Archmonger Archmonger added the flag-good-first-issue A well defined and self-contained task. label Feb 13, 2023
@rmorshea rmorshea added the priority-3-low May be resolved one any timeline. label Feb 14, 2023
@rmorshea rmorshea removed this from the Luxury milestone Feb 21, 2023
@rmorshea rmorshea changed the title Improve Pre-commit CI config Add Back Pre-Commit Hooks Jun 7, 2023
@Smit-Parmar Smit-Parmar mentioned this issue Jun 8, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flag-good-first-issue A well defined and self-contained task. priority-3-low May be resolved one any timeline. type-ci About change and updates to the Continuous Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added pre-commit hook Smit-Parmar/reactpy
2 participants
@rmorshea @Archmonger