Generated code should use Array.Empty or constant field where possible

[TimothyMakkison]

Array.Empty

Each method call with no parameters allocates an empty params and type array. To prevent unneeded allocations Array.Empty should be used instead.

public async global::System.Threading.Tasks.Task<global::System.Net.Http.HttpResponseMessage> GetIndex()
{
    var ______arguments = new object[] {  }; // unneeded allocation
    var ______func = requestBuilder.BuildRestResultFuncForMethod("GetIndex", new global::System.Type[] {  } );
    ...

With Array.Empty

public async global::System.Threading.Tasks.Task<global::System.Net.Http.HttpResponseMessage> GetIndex()
{
    var ______arguments = global::System.Array.Empty<object>();
    var ______func = requestBuilder.BuildRestResultFuncForMethod(""GetIndex"", global::System.Array.Empty<global::System.Type>() );

typeParameters

The parameterTypes array remains the same between calls, this could be moved out into a private static or private readonly field. The generator will have to falback to the current method if one of the parameters is a generic type scoped to the method.

Before

public async global::System.Threading.Tasks.Task<global::Refit.Tests.UserSearchResult> FindUsers(string @q)
{
    var ______arguments = new object[] { @q };
    var ______func = requestBuilder.BuildRestResultFuncForMethod(""FindUsers"", new global::System.Type[] { typeof(string) } );
    ...

After

private static global::System.Type[] typeArray1 = new global::System.Type[] { typeof(string) };

public async global::System.Threading.Tasks.Task<global::Refit.Tests.UserSearchResult> FindUsers(string @q)
{
    var ______arguments = new object[] { @q };
    var ______func = requestBuilder.BuildRestResultFuncForMethod(""FindUsers"", typeArray1 );
    ...

Generic typeParameters

private static global::System.Type[]? typeArray1 = null;

public async global::System.Threading.Tasks.Task<global::Refit.Tests.UserSearchResult> FindUsers<T>(string @q, [Body]T body)
{
    if (typeArray1 == null)
    {
        typeArray1 = new global::System.Type[] { typeof(string), typeof(T) };
    }
    var ______arguments = new object[] { @q };
    var ______func = requestBuilder.BuildRestResultFuncForMethod(""FindUsers"", typeArray1 );
    ...

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.