Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(find): add undefined to return type #3970

Merged
merged 3 commits into from
Jul 29, 2018
Merged

fix(find): add undefined to return type #3970

merged 3 commits into from
Jul 29, 2018

Conversation

cartant
Copy link
Collaborator

@cartant cartant commented Jul 28, 2018

Description:

Fixes the return types for the find operator to indicate that undefined is a value that could be emitted.

Removes unnecessary overload signatures and adds dtslint tests.

Related issue (if exists): #3969

@coveralls
Copy link

coveralls commented Jul 28, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 96.737% when pulling 7cfaccd on cartant:issue-3969 into 5c52a73 on ReactiveX:master.

@benlesh benlesh merged commit 5a6c90f into ReactiveX:master Jul 29, 2018
@cartant cartant mentioned this pull request Jul 29, 2018
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Aug 28, 2018
@cartant cartant deleted the issue-3969 branch September 24, 2020 07:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benlesh benlesh benlesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cartant @coveralls @benlesh