Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

static pipe operator is not the same as Observable.pipe #4109

Closed
dkosasih opened this issue Sep 7, 2018 · 1 comment
Closed

static pipe operator is not the same as Observable.pipe #4109

dkosasih opened this issue Sep 7, 2018 · 1 comment

Comments

@dkosasih
Copy link
Contributor

dkosasih commented Sep 7, 2018

Bug Report

Current Behavior
Static pipe function in the recently merged fixed (#3945) for Observable pipe function signature overload is not in sync.

Reproduction
Rest parameters overload like below show also exists in static pipe function.

pipe<A, B, C, D, E, F, G, H, I>(op1: OperatorFunction<T, A>, op2: OperatorFunction<A, B>, op3: OperatorFunction<B, C>, op4: OperatorFunction<C, D>, op5: OperatorFunction<D, E>, op6: OperatorFunction<E, F>, op7: OperatorFunction<F, G>, op8: OperatorFunction<G, H>, op9: OperatorFunction<H, I>, ...operations: OperatorFunction<any, any>[]): Observable<{}>;

Expected behavior
It should behave the same as Observable pipe function and be able to compose static pipe functions separately and pass on to Observable pipe.

Environment

  • RxJS version: 6.3.2
dkosasih added a commit to dkosasih/rxjs that referenced this issue Sep 7, 2018
@dkosasih
fix(pipe): align static pipe to Observable pipe rest parameters overl…
de36e97 
…oad (ReactiveX#4109)
@dkosasih dkosasih mentioned this issue Sep 7, 2018
Merged
dkosasih added a commit to dkosasih/rxjs that referenced this issue Sep 8, 2018
@dkosasih
fix(pipe): align static pipe to Observable pipe rest parameters overl…
137cb92 
…oad (ReactiveX#4109)
dkosasih added a commit to dkosasih/rxjs that referenced this issue Sep 8, 2018
@dkosasih
test(pipe): add dtslint test for rest parameters overload (ReactiveX#…
9499645 
…4109)
benlesh pushed a commit that referenced this issue Sep 25, 2018
@dkosasih @benlesh
fix(pipe): align static pipe to Observable pipe rest parameters overl… (
8c607e9 
#4112)

* fix(pipe): align static pipe to Observable pipe rest parameters overload (#4109)

* test(pipe): add dtslint test for rest parameters overload (#4109)
@cartant
Copy link
Collaborator

cartant commented Sep 27, 2018

Closing this, as it has been addressed in a PR.

@cartant cartant closed this as completed Sep 27, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Oct 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cartant @dkosasih