fix: chain subscriptions for interop with finalize #5239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlesh
reviewed
Jan 20, 2020
benlesh
requested changes
Jan 27, 2020
@benlesh I had a quick look at this and the issue with putting this functionality into |
cartant
changed the title
|
Closed by #5333 |
|
Nope, #5333 doesn't close this. Rather, this PR needs to be refactored to use |
cartant
changed the title
benlesh
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The change in this PR is very similar to the changes that were made in #5059: when an interop subscriber is created within
finalize, it'll be wrapped when a subscription is made to the source observable inFinallyOperator#call. The interop subscriber needs to be added to the subscription so that unsubscription chains property and the finalize callback is invoked.The adding of the interop subscription is now handled in
subscribeWith- which was added in #5333.This PR also includes a failing test that is fixed by the above change.
Related issue (if exists): #5237