Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-react-imports changes line endings (LF -> CRLF) #281

Open
tpettrov opened this issue Oct 22, 2020 · 2 comments
Open

update-react-imports changes line endings (LF -> CRLF) #281

tpettrov opened this issue Oct 22, 2020 · 2 comments

Comments

@tpettrov
Copy link

I recently started update-react-imports and it works as expected but re-wrote the line endings from LF to CRLF, probably because I'm on Windows but would expect that it doesn't change them if possible.

@threepointone
Copy link
Contributor

This is functionality from jscodeshift, so the issue should probably be filed there. However, one of the assumptions we have about people running codemods, is that they also run something like prettier (or whatever your code formatter is) manually after running the codemod. Does that advice seem reasonable in this case?

@tpettrov
Copy link
Author

Advice is reasonable due to the fact that the issue should probably be filled to jscodeshift :) Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants