-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle inline <style>s #35
Comments
Inline styles should be fine... I'll try to look into this soon and determine what the problem is. |
Cause looks to be internal stylesheets. Inline styles are being handled correctly the 'JSX way' but internal stylesheets are not. <style>
h1 { color: red; }
</style> needs to convert to <style>{"\
h1 { color: red; }\
"}</style> |
Thanks! Sounds like we need custom handling. That can be done :) (as an aside, using |
We didn't need those newlines anyway! |
So #36 fixes internal stylesheets, but the battle against curly braces is still far from over. It's easily handled in |
@Daniel15, can you release a new version on NPM with this fix? |
@ssorallen Pushed to NPM as 0.2.5 👍 |
I've been playing around with react-magic, testing it on a number of different websites. I got one syntax error quite often. I've included a few examples of this error.
How to reproduce For each site I opened up the debug console (in Firefox), and ran this command (taken from the bookmarklet):
Maybe it has to do with inline styles?
The text was updated successfully, but these errors were encountered: