[chore] Return null for portal when modal is closed

reactjs · Jul 2, 2017 · e56c414 · e56c414
1 parent 55920f9
commit e56c414
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/specs/Modal.spec.js b/specs/Modal.spec.js
@@ -30,6 +30,11 @@ describe('State', () => {
     expect(ReactDOM.findDOMNode(mcontent(modal))).toNotExist();
   });
 
+  it('doesn\'t render the portal if modal is closed', () => {
+    const modal = renderModal({}, 'hello');
+    expect(ReactDOM.findDOMNode(modal.portal)).toNotExist();
+  })
+
   it('has default props', () => {
     const node = document.createElement('div');
     Modal.setAppElement(document.createElement('div'));

diff --git a/src/components/ModalPortal.js b/src/components/ModalPortal.js
@@ -265,7 +265,7 @@ export default class ModalPortal extends Component {
     const contentStyles = className ? {} : defaultStyles.content;
     const overlayStyles = overlayClassName ? {} : defaultStyles.overlay;
 
-    return this.shouldBeClosed() ? <div /> : (
+    return this.shouldBeClosed() ? null : (
       <div
         ref={this.setOverlayRef}
         className={this.buildClassName('overlay', overlayClassName)}