[fixed] portal node will be reparented if necessary on props change

reactjs · Jul 4, 2018 · e5a80d6 · e5a80d6
1 parent f715a69
commit e5a80d6
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/components/Modal.js b/src/components/Modal.js
@@ -134,15 +134,15 @@ class Modal extends Component {
       this.node.className = portalClassName;
     }
 
-    // Stop unnecessary renders if modal is remaining closed
-    if (!prevProps.isOpen && !isOpen) return;
-
     const { prevParent, nextParent } = snapshot;
     if (nextParent !== prevParent) {
       prevParent.removeChild(this.node);
       nextParent.appendChild(this.node);
     }
 
+    // Stop unnecessary renders if modal is remaining closed
+    if (!prevProps.isOpen && !isOpen) return;
+
     !isReact16 && this.renderPortal(this.props);
   }