From edfd2a9ead0bdee75c36cf6625d2b9a4f2552376 Mon Sep 17 00:00:00 2001 From: Arijit Bhattacharya Date: Fri, 20 Jul 2018 23:10:31 +0530 Subject: [PATCH] Add explicit comments as suggested in PR review --- docs/styles/transitions.md | 23 +++++++++++++++++------ 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/docs/styles/transitions.md b/docs/styles/transitions.md index 6c2682d1..b39ffa62 100644 --- a/docs/styles/transitions.md +++ b/docs/styles/transitions.md @@ -27,10 +27,19 @@ whose `afterOpen` and `beforeClose` classes have not been set via the the above class names and pass an object to your modal's `className` prop as described in the [previous section](classes.md). -In order for the close transition to take effect, you will also need to pass -the `closeTimeoutMS={150}` prop to each of your modals. +In order for the fade transition to work, you need to inform the `` about the transition time required for the animation. -Also, if you are using `v3` which supports **React 16**, the close transition works [only if you use](https://github.com/reactjs/react-modal/issues/530#issuecomment-335208533) the `isOpen` prop to toggle the visibility of the modal. +Like this + +```javascript + +``` + +`closeTimeoutMS` is expressed in milliseconds. + +The `closeTimeoutMS` value and the value used in CSS or `style` prop passed to `` needs to be the same. + +Warning: if you are using **React 16**, the close transition works [only if you use](https://github.com/reactjs/react-modal/issues/530#issuecomment-335208533) the `isOpen` prop to toggle the visibility of the modal. Do not conditionally render the ``. @@ -38,7 +47,7 @@ Instead of this ```javascript { - this.state.showModal ? + this.state.showModal &&

Add modal content here

- : null } ``` @@ -63,6 +71,9 @@ Instead of this >

Add modal content here

- : null } ``` + +React Modal has adopted the [stable Portal API](https://reactjs.org/docs/portals.html) API as exposed in React 16. + +And `createProtal` API from React 16 [no longer allow](https://github.com/facebook/react/issues/10826#issuecomment-355719729) developers to intervene the unmounting of the portal component.