-
-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prebuilt versions in /dist are broken #209
Comments
This is fixed in the latest version see https://github.com/reactjs/react-tabs#installing |
I noticed, awesome! Although it seems only the production version is working at the moment, the development version will throw with So I guess we should either tell people to include <script src="https://unpkg.com/prop-types/prop-types.js"></script> in their code before the react-tabs |
It is mentioned in the Readme and in the examples |
Aww yeah, missed that! Apologies. And thanks again for all the work you put in. 👍 |
See title. I might be missing someting but it seems those dist files should all Just Work™, the only requirement being that
React
andReactDOM
are included on the page. The minified version does load, but it gives a cryptic error in the console when rendering any of the components. The unminified version throws an error when merely using a component. You can find an example here: https://codepen.io/joep/pen/oGWxJm. You'll have to open your browser console to see the errors, as Codepen's built in one doesn't show them.I guess priority on this issue shouldn't be super high, as it seems this has been broken for a while (since 1.0.0, actually) and no one seems to have complained since. ;)
P.S. If you've come here in search of a way to test
react-tabs
directly in your browser, try a tool like codesandbox.io or webpackbin.com.Here's a CodeSandbox example: https://codesandbox.io/s/3x010xpw8m.
The text was updated successfully, but these errors were encountered: