Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlockHound and debug agent tests use toolchains #3919

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

chemicL
Copy link
Member

@chemicL chemicL commented Nov 6, 2024

Running BlockHound and debug agent tests using JDK greater than 8 would fail due to improper version checks. JavaVersion.current() reports the JDK used to run gradle, while we are interested in the JDK currently in use by the current toolchain.

Running BlockHound and debug agent tests using JDK greater than 8 would
fail due to improper version checks. `JavaVersion.current()` reports the
JDK used to run gradle, while we are interested in the JDK currently in
use by the current toolchain.

Signed-off-by: Dariusz Jędrzejczyk <dariusz.jedrzejczyk@broadcom.com>
@chemicL chemicL added the type/bug A general bug label Nov 6, 2024
@chemicL chemicL requested a review from a team as a code owner November 6, 2024 23:36
@violetagg
Copy link
Member

openjdk version "21.0.5" 2024-10-15 LTS
OpenJDK Runtime Environment Corretto-21.0.5.11.1 (build 21.0.5+11-LTS)
OpenJDK 64-Bit Server VM Corretto-21.0.5.11.1 (build 21.0.5+11-LTS, mixed mode, sharing)

./gradlew publishToMavenLocal

* Where:
Build file '/.../reactor-core/reactor-tools/build.gradle' line: 140

* What went wrong:
A problem occurred configuring project ':reactor-tools'.
> Could not resolve all dependencies for configuration ':reactor-tools:compileClasspath'.
   > Failed to calculate the value of task ':reactor-core:compileJava9Java' property 'javaCompiler'.
      > No matching toolchains found for requested specification: {languageVersion=9, vendor=any, implementation=vendor-specific} for MAC_OS on aarch64.
         > No locally installed toolchains match and the configured toolchain download repositories aren't able to provide a match either.

@chemicL
Copy link
Member Author

chemicL commented Nov 7, 2024

@chemicL chemicL merged commit 38f9628 into 3.6.x Nov 8, 2024
8 checks passed
@chemicL chemicL deleted the blockhound-and-agent-tests-use-toolchains branch November 8, 2024 12:04
chemicL added a commit that referenced this pull request Nov 8, 2024
@chemicL chemicL added this to the 3.6.12 milestone Nov 8, 2024
@chemicL chemicL added type/test A change in test sources and removed type/bug A general bug labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/test A change in test sources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants