Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Feature request]: Add a link to navigate to all plays #280

Closed
vasantisuthar opened this issue Jun 5, 2022 · 19 comments
Closed

✨ [Feature request]: Add a link to navigate to all plays #280

vasantisuthar opened this issue Jun 5, 2022 · 19 comments

Comments

@vasantisuthar
Copy link
Contributor

Add a link to navigate to all plays when play is not found

2022-06-05 (2)

It would be good if we add a text that will link to all the plays back when the play is not found.

I would like to work on this issue.

@Sachin-chaurasiya
Copy link
Member

@vasantisuthar , One more thing we can do here is instead of play not found , we can say play not found for {searchText}.

@MOHAMED-EHAB-DEV
Copy link
Contributor

One more thing we can create two buttons one for the home page and the other is for plays page

@vasantisuthar
Copy link
Contributor Author

There is already a React play home button at the top, we shall only include all plays button, what say @Sachin-chaurasiya @Programming-School-Pro-Coding

@atapas
Copy link
Member

atapas commented Jun 9, 2022

There is already a React play home button at the top, we shall only include all plays button, what say @Sachin-chaurasiya @Programming-School-Pro-Coding

But you are already on the plays page when this message appears. How about that?

@MOHAMED-EHAB-DEV
Copy link
Contributor

There is already a React play home button at the top, we shall only include all plays button, what say @Sachin-chaurasiya @Programming-School-Pro-Coding

Ok 👌

@MOHAMED-EHAB-DEV
Copy link
Contributor

There is already a React play home button at the top, we shall only include all plays button, what say @Sachin-chaurasiya @Programming-School-Pro-Coding

But you are already on the plays page when this message appears. How about that?

In the 404 react file we will add new button

@Sachin-chaurasiya
Copy link
Member

@vasantisuthar , One more thing we can do here is instead of play not found , we can say play not found for {searchText}.

@atapas , Your thought on this.

@atapas
Copy link
Member

atapas commented Jun 30, 2022

@Sachin-chaurasiya

I think we shouldn't overengineer this one. A reasonable fix to me is to enhance the message with the search text as you suggested. Can we get it done? I see the issue has been assigned to @vasantisuthar

@Sachin-chaurasiya
Copy link
Member

@Sachin-chaurasiya

I think we shouldn't overengineer this one. A reasonable fix to me is to enhance the message with the search text as you suggested. Can we get it done? I see the issue has been assigned to @vasantisuthar

@atapas , Yes.

@Sachin-chaurasiya
Copy link
Member

@vasantisuthar , Let me know, and I can pick this up.

@vasantisuthar
Copy link
Contributor Author

Okay so I can update the text message.

@atapas
Copy link
Member

atapas commented Aug 2, 2022

@vasantisuthar / @Sachin-chaurasiya this issue is around for a long time. Can any of you please take care?

@Sachin-chaurasiya
Copy link
Member

@vasantisuthar / @Sachin-chaurasiya this issue is around for a long time. Can any of you please take care?

Sure @atapas, @vasantisuthar let me know if you need any help on this.

@vasantisuthar
Copy link
Contributor Author

@Sachin-chaurasiya does it really need to be modified, I guess we shouldn't now as the page looks clear to me.

@Sachin-chaurasiya
Copy link
Member

Sachin-chaurasiya commented Aug 2, 2022

@Sachin-chaurasiya does it really need to be modified, I guess we shouldn't now as the page looks clear to me.

@vasantisuthar , we can do something like this if there is a search term.

image

@vasantisuthar
Copy link
Contributor Author

Cool I will do it, I tried to do it before but the search bar wasn't shown up on the browser, so waited for that.

@vasantisuthar
Copy link
Contributor Author

Cool I will do it, I tried to do it before but the search bar wasn't shown up on the browser, so waited for that.

Will submit this on Sunday

@github-actions
Copy link

github-actions bot commented Dec 7, 2022

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

@github-actions github-actions bot added the stale label Dec 7, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 14, 2022
@atapas atapas reopened this Sep 7, 2023
@atapas atapas removed the stale label Sep 7, 2023
@priyankarpal
Copy link
Member

already added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants