Should we release 0.70.9?

[kelset]

Current Release: 0.70.8

Conversations on this thread are limited:

• major release issues.
• qualified cherry-pick requests of commits on main that did not make the previous patch version.

Please include a link to the specific commit on main to be cherry-picked, for example: facebook/react-native@bd2b7d6

In other words, if you cannot point to a particular commit on main, then your request likely belongs as a new issue.
If the issue is a major release issues, please reference the issue here.

---

List of qualified picks

Local commits to backport to main

[kelset]

From @mikeduminy in prev discussion:

Hey there, there is an issue in Hermes that prevents one from loading large, complex bundles in development. The change is to simply increase the max size of the stack.
The change hasn't been merged yet but it targets the stable branch within Hermes for 0.70. My guess is some coordination needs to happen to first merge this then bump this in RN. I'm happy to help where ever needed.

facebook/hermes#924

[lunaleaps]

Trying to play catch up here, is the take-away from this comment that we need to pick the following:

• facebook/hermes@03f2dff
• facebook/hermes@1b759f4

onto Hermes rn/0.70-stable? And then publish a new Hermes tag, and update it on this branch via ./scripts/hermes/bump-hermes-version.js ... for this patch?

If yes, here's the PR of the picks for Hermes: facebook/hermes#969

[kelset]

@lunaleaps yeah good call - thanks for doing the proper check. Yes those are the two commits, thanks for setting that PR up.

I think you can go ahead and merge, then trigger the Hermes workflow https://github.com/facebook/hermes/actions/workflows/create-tag.yml using as commit reference the hash of the last commit (after having merged the PR) in the Hermes https://github.com/facebook/hermes/commits/rn/0.70-stable branch. That should generate a new Hermes tag along the lines of hermes-2023-04-XX-RNv0.70.8-<hash> (similar to https://github.com/facebook/hermes/releases/tag/hermes-2022-09-14-RNv0.70.1-2a6b111ab289b55d7b78b5fdf105f466ba270fd7, basically).

And once that one is generated, we can go in the 0.70 branch in RN core: https://github.com/facebook/react-native/tree/0.70-stable and run the ./scripts/hermes/bump-hermes-version.js -t <the_hermes_tag> with the newly generated tag, and push that commit.

[lunaleaps]

done! Thanks for the detailed instructions!

[kelset]

once we tested them in 0.72's next RC (RC1) - let's cherry pick @NickGerleman's fixes for TextInput (EditText) (in order):

• facebook/react-native@1743dd7
• facebook/react-native@b9e2627
• facebook/react-native@cc0ba57
• facebook/react-native@8c9c8ba
• facebook/react-native@0869ea2
• facebook/react-native@5791cf1
• facebook/react-native@104cb7f
• facebook/react-native@b384bb6
• facebook/react-native@92b8981

And before that, this commit: facebook/react-native@8a0fe30

[kelset]

PR: facebook/react-native#36875

[kelset]

facebook/react-native@b07cf33 to address performance regressions