Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.74] Fix bug where absolute nodes were not insetted correctly in certain cases #154

Closed
joevilches opened this issue Mar 13, 2024 · 1 comment
Assignees

Comments

@joevilches
Copy link

Target Branch(es)

0.74

Link to commit or PR to be picked

facebook/react-native#43417

Description

0.74 came with major changes to Yoga, one of them being support for position: static. Well that had a semi-major bug in its implementation where insetting absolute nodes would not work if there were differing flex directions somewhere in its ancestry up to the containing block. I believe this should be picked before users start using static and this becomes a breaking change. This has no impact on trees that do not use static.

@cortinico cortinico changed the title Fix bug where absolute nodes were not insetted correctly in certain cases [0.74] Fix bug where absolute nodes were not insetted correctly in certain cases Mar 13, 2024
@huntie huntie moved this from Inbox to Done / Picked in React Native 0.74 Releases Mar 18, 2024
@cortinico
Copy link
Collaborator

Picked ✅ Will be included in RC4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done / Picked
Development

No branches or pull requests

2 participants