Skip to content

Commit

Permalink
fix: removing our dependency on trim (#1029)
Browse files Browse the repository at this point in the history
[![PR App][icn]][demo] |
:-------------------:|

## 🧰 Changes

Installing the markdown package throws these warnings from NPM for the
`trim` package:

```
npm warn deprecated trim@1.0.1: Use String.prototype.trim() instead
npm warn deprecated trim@0.0.1: Use String.prototype.trim() instead
npm warn deprecated trim@0.0.1: Use String.prototype.trim() instead
```

It seems that we're no longer using `trim` anymore(?) so I'm removing it
from being a dependency.

##### Before

```
> npm ls trim
@readme/markdown@7.9.0
├─┬ @readme/markdown-legacy@npm:@readme/markdown@6.87.1
│ └─┬ remark-parse@8.0.3
│   └── trim@0.0.1
└── trim@1.0.1
```

##### After

```
@readme/markdown@7.9.0
└─┬ @readme/markdown-legacy@npm:@readme/markdown@6.87.1
  └─┬ remark-parse@8.0.3
    └── trim@0.0.1
```

## 🧬 QA & Testing

All tests were still passing and the dist still gets built fine with
`npm run build`.


[demo]: https://markdown-pr-PR_NUMBER.herokuapp.com
[prod]: https://SUBDOMAIN.readme.io
[icn]:
https://user-images.githubusercontent.com/886627/160426047-1bee9488-305a-4145-bb2b-09d8b757d38a.svg
  • Loading branch information
erunion authored Nov 4, 2024
1 parent 58e3b38 commit 656187d
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
7 changes: 0 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@
"remark-gfm": "^4.0.0",
"remark-mdx": "^3.0.0",
"remark-parse": "^11.0.0",
"trim": "^1.0.1",
"unified": "^11.0.4",
"unist-util-flatmap": "^1.0.0",
"unist-util-visit": "^5.0.0",
Expand Down

0 comments on commit 656187d

Please sign in to comment.