Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: removing our dependency on
trim
(#1029)
[![PR App][icn]][demo] | :-------------------:| ## 🧰 Changes Installing the markdown package throws these warnings from NPM for the `trim` package: ``` npm warn deprecated trim@1.0.1: Use String.prototype.trim() instead npm warn deprecated trim@0.0.1: Use String.prototype.trim() instead npm warn deprecated trim@0.0.1: Use String.prototype.trim() instead ``` It seems that we're no longer using `trim` anymore(?) so I'm removing it from being a dependency. ##### Before ``` > npm ls trim @readme/markdown@7.9.0 ├─┬ @readme/markdown-legacy@npm:@readme/markdown@6.87.1 │ └─┬ remark-parse@8.0.3 │ └── trim@0.0.1 └── trim@1.0.1 ``` ##### After ``` @readme/markdown@7.9.0 └─┬ @readme/markdown-legacy@npm:@readme/markdown@6.87.1 └─┬ remark-parse@8.0.3 └── trim@0.0.1 ``` ## 🧬 QA & Testing All tests were still passing and the dist still gets built fine with `npm run build`. [demo]: https://markdown-pr-PR_NUMBER.herokuapp.com [prod]: https://SUBDOMAIN.readme.io [icn]: https://user-images.githubusercontent.com/886627/160426047-1bee9488-305a-4145-bb2b-09d8b757d38a.svg
- Loading branch information