Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing our dependency on trim #1029

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

erunion
Copy link
Member

@erunion erunion commented Nov 4, 2024

PR App

🧰 Changes

Installing the markdown package throws these warnings from NPM for the trim package:

npm warn deprecated trim@1.0.1: Use String.prototype.trim() instead
npm warn deprecated trim@0.0.1: Use String.prototype.trim() instead
npm warn deprecated trim@0.0.1: Use String.prototype.trim() instead

It seems that we're no longer using trim anymore(?) so I'm removing it from being a dependency.

Before
> npm ls trim
@readme/markdown@7.9.0
├─┬ @readme/markdown-legacy@npm:@readme/markdown@6.87.1
│ └─┬ remark-parse@8.0.3
│   └── trim@0.0.1
└── trim@1.0.1
After
@readme/markdown@7.9.0
└─┬ @readme/markdown-legacy@npm:@readme/markdown@6.87.1
  └─┬ remark-parse@8.0.3
    └── trim@0.0.1

🧬 QA & Testing

All tests were still passing and the dist still gets built fine with npm run build.

@erunion erunion added the refactor Issues about tackling technical debt label Nov 4, 2024
@erunion erunion merged commit 656187d into next Nov 4, 2024
13 checks passed
@erunion erunion deleted the chore/remove-trim-dependency branch November 4, 2024 19:51
rafegoldberg pushed a commit that referenced this pull request Nov 7, 2024
## Version 7.10.0
### ✨ New & Improved

* columns ([#1008](#1008)) ([1a3625a](1a3625a))

### 🛠 Fixes & Updates

* **deps:** bump @mdx-js/mdx from 3.0.1 to 3.1.0 ([#1023](#1023)) ([cf28a98](cf28a98))
* **deps:** bump @readme/emojis from 5.1.0 to 6.0.0 ([#1025](#1025)) ([9feeb50](9feeb50)), closes [readmeio/emojis#85](readmeio/emojis#85) [#85](#85)
* **deps:** bump core-js from 3.38.1 to 3.39.0 ([#1027](#1027)) ([3963833](3963833)), closes [/github.com/tc39/proposal-iterator-helpers/issues/284#event-14549961807](https://github.com/readmeio//github.com/tc39/proposal-iterator-helpers/issues/284/issues/event-14549961807)
* **deps:** bump debug from 4.3.4 to 4.3.7 ([#1022](#1022)) ([8830a5d](8830a5d)), closes [debug-js/debug#819](debug-js/debug#819) [debug-js/debug#969](debug-js/debug#969) [debug-js/debug#969](debug-js/debug#969) [#926](#926) [#819](#819) [#926](#926)
* **deps:** bump emoji-regex from 10.3.0 to 10.4.0 ([#1020](#1020)) ([8b4e8c7](8b4e8c7)), closes [#113](#113)
* **deps:** bump estree-util-value-to-estree from 3.1.1 to 3.2.1 ([#1026](#1026)) ([19f2ff4](19f2ff4))
* **deps:** bump hast-util-from-html from 2.0.1 to 2.0.3 ([#1028](#1028)) ([97a7ae7](97a7ae7))
* **deps:** bump remark-mdx from 3.0.1 to 3.1.0 ([#1021](#1021)) ([0b3b087](0b3b087))
* removing our dependency on `trim` ([#1029](#1029)) ([656187d](656187d))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor

This PR was released!

🚀 Changes included in v7.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issues about tackling technical debt released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants