feat: fix incompatable emphasis #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafegoldberg
reviewed
Oct 7, 2024
rafegoldberg
approved these changes
Oct 7, 2024
kellyjosephprice
added a commit
that referenced
this pull request
Oct 8, 2024
This reverts commit 811fad4.
|
This PR was released!🚀 Changes included in v7.6.7 |
kellyjosephprice
added a commit
that referenced
this pull request
Oct 28, 2024
| 📖 [PR App][pr] | 🎫 Resolve CX-1135, RM-11085 | | :-------------: | :-----------------: | ## 🧰 Changes Fixes incompatable emphasis during the migration. I [fixed this](#988) in `@readme/mdx`, but I think it'll be nicer to keep the migration specific stuff in the main app. ## 💁 Customer Impact <!-- PLEASE DESCRIBE IF THIS CHANGE AFFECTS CUSTOMERS AND HOW --> <!-- This is extremely useful for Tony and Marc writing the changelog! --> ## 🧬 QA & Testing - [ ] insert the string `*the recommended initial action is to**initiate a[reversal operation (rollback)](https://docs.jupico.com/reference/ccrollback)**. *` into a page - [ ] note the bold and italics - [ ] migrate the project - [ ] confirm that the bold and italics render the same in the dash and hub <!-- --> - [Broken on next][next]. - [Working in this PR][pr]! [next]: https://next.readme.ninja [pr]: https://readme-pr-12963.readme.ninja [ui]: https://readme-pr-12963.readme.ninja/ui <!-- Uncomment and unescape this if you don't want a PR app! --> <!-- \[skip preview\] -->
kellyjosephprice
added a commit
that referenced
this pull request
Oct 28, 2024
| 📖 [PR App][pr] | 🎫 Resolve CX-1135, RM-11085 | | :-------------: | :-----------------: | ## 🧰 Changes Fixes incompatable emphasis during the migration. I [fixed this](#988) in `@readme/mdx`, but I think it'll be nicer to keep the migration specific stuff in the main app. ## 💁 Customer Impact <!-- PLEASE DESCRIBE IF THIS CHANGE AFFECTS CUSTOMERS AND HOW --> <!-- This is extremely useful for Tony and Marc writing the changelog! --> ## 🧬 QA & Testing - [ ] insert the string `*the recommended initial action is to**initiate a[reversal operation (rollback)](https://docs.jupico.com/reference/ccrollback)**. *` into a page - [ ] note the bold and italics - [ ] migrate the project - [ ] confirm that the bold and italics render the same in the dash and hub <!-- --> - [Broken on next][next]. - [Working in this PR][pr]! [next]: https://next.readme.ninja [pr]: https://readme-pr-12963.readme.ninja [ui]: https://readme-pr-12963.readme.ninja/ui <!-- Uncomment and unescape this if you don't want a PR app! --> <!-- \[skip preview\] -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Attempts to migrate more buggy emphasis syntax.
🧬 QA & Testing