From d144522f423352b89a7a879a86552b86b7eb23bc Mon Sep 17 00:00:00 2001
From: Kelly Joseph Price <kellyjosephprice@gmail.com>
Date: Fri, 4 Oct 2024 15:53:25 -0700
Subject: [PATCH 1/2] feat: fix incompatable emphasis

---
 __tests__/compilers/compatability.test.tsx | 11 ++++--
 processor/transform/compatability.ts       | 39 +++++++++++++++++-----
 2 files changed, 39 insertions(+), 11 deletions(-)

diff --git a/__tests__/compilers/compatability.test.tsx b/__tests__/compilers/compatability.test.tsx
index 53ae0d384..e5e18f231 100644
--- a/__tests__/compilers/compatability.test.tsx
+++ b/__tests__/compilers/compatability.test.tsx
@@ -205,8 +205,6 @@ This is an image: <img src="http://example.com/#\\>" >
   });
 
   describe('<HTMLBlock> wrapping', () => {
-    // configure({ defaultIgnore: undefined });
-
     const rawStyle = `<style data-testid="style-tag">
     p {
       color: red;
@@ -332,6 +330,15 @@ This is an image: <img src="http://example.com/#\\>" >
     `);
   });
 
+  it('adds whitespace surrounding phrasing content (emphasis, strong, etc)', () => {
+    const md = `**bold **and also_ italic_ and***bold italic***aaaaaah`;
+
+    const rmdx = mdx(rdmd.mdast(md));
+    expect(rmdx).toMatchInlineSnapshot(`
+      "**bold** and also *italic* and ***bold italic*** aaaaaah
+      "
+    `);
+  });
 
   it('correctly parses and transforms image magic block with legacy data', () => {
     const md = `
diff --git a/processor/transform/compatability.ts b/processor/transform/compatability.ts
index 6ba3f64e0..959b68887 100644
--- a/processor/transform/compatability.ts
+++ b/processor/transform/compatability.ts
@@ -5,18 +5,39 @@ import { phrasing } from 'mdast-util-phrasing';
 
 const strongTest = (node: Node): node is Strong | Emphasis => ['emphasis', 'strong'].includes(node.type);
 
-const compatibilityTransfomer = (): Transform => tree => {
-  const trimEmphasis = (node: Emphasis | Strong) => {
-    visit(node, 'text', child => {
-      child.value = child.value.trim();
-      return EXIT;
-    });
+const trimEmphasis = (node: Emphasis | Strong) => {
+  visit(node, 'text', child => {
+    child.value = child.value.trim();
+    return EXIT;
+  });
+
+  return node;
+};
 
-    return node;
-  };
+const addSpaceBefore = (index: number, parent: Parent) => {
+  if (!(index > 0 && parent.children[index - 1])) return;
+
+  const prev = parent.children[index - 1];
+  if (!('value' in prev) || prev.value.endsWith(' ') || prev.type === 'escape') return;
+
+  parent.children.splice(index, 0, { type: 'text', value: ' ' });
+};
 
-  visit(tree, strongTest, node => {
+const addSpaceAfter = (index: number, parent: Parent) => {
+  if (!(index < parent.children.length - 1 && parent.children[index + 1])) return;
+
+  const nextChild = parent.children[index + 1];
+  if (!('value' in nextChild) || nextChild.value.startsWith(' ')) return;
+
+  parent.children.splice(index + 1, 0, { type: 'text', value: ' ' });
+};
+
+const compatibilityTransfomer = (): Transform => tree => {
+  visit(tree, strongTest, (node, index, parent: Parent) => {
     trimEmphasis(node);
+    addSpaceBefore(index, parent);
+    addSpaceAfter(index, parent);
+
     return SKIP;
   });
 

From 3fe94bdb26bb29474c6710b9faa439a4602a68eb Mon Sep 17 00:00:00 2001
From: Kelly Joseph Price <kellyjosephprice@gmail.com>
Date: Mon, 7 Oct 2024 11:15:39 -0700
Subject: [PATCH 2/2] only fix if fixing

---
 __tests__/compilers/compatability.test.tsx |  6 ++--
 processor/transform/compatability.ts       | 35 ++++++++++++----------
 2 files changed, 23 insertions(+), 18 deletions(-)

diff --git a/__tests__/compilers/compatability.test.tsx b/__tests__/compilers/compatability.test.tsx
index e5e18f231..435db28d7 100644
--- a/__tests__/compilers/compatability.test.tsx
+++ b/__tests__/compilers/compatability.test.tsx
@@ -330,12 +330,12 @@ This is an image: <img src="http://example.com/#\\>" >
     `);
   });
 
-  it('adds whitespace surrounding phrasing content (emphasis, strong, etc)', () => {
-    const md = `**bold **and also_ italic_ and***bold italic***aaaaaah`;
+  it('moves whitespace surrounding phrasing content (emphasis, strong, etc) to the appropriate place', () => {
+    const md = `**bold **and also_ italic_ and*** bold italic***aaaaaah`;
 
     const rmdx = mdx(rdmd.mdast(md));
     expect(rmdx).toMatchInlineSnapshot(`
-      "**bold** and also *italic* and ***bold italic*** aaaaaah
+      "**bold** and also *italic* and ***bold italic***aaaaaah
       "
     `);
   });
diff --git a/processor/transform/compatability.ts b/processor/transform/compatability.ts
index 959b68887..667327aaf 100644
--- a/processor/transform/compatability.ts
+++ b/processor/transform/compatability.ts
@@ -1,19 +1,10 @@
 import { Emphasis, Image, Strong, Node, Parent } from 'mdast';
-import { EXIT, SKIP, visit } from 'unist-util-visit';
 import { Transform } from 'mdast-util-from-markdown';
 import { phrasing } from 'mdast-util-phrasing';
+import { visit } from 'unist-util-visit';
 
 const strongTest = (node: Node): node is Strong | Emphasis => ['emphasis', 'strong'].includes(node.type);
 
-const trimEmphasis = (node: Emphasis | Strong) => {
-  visit(node, 'text', child => {
-    child.value = child.value.trim();
-    return EXIT;
-  });
-
-  return node;
-};
-
 const addSpaceBefore = (index: number, parent: Parent) => {
   if (!(index > 0 && parent.children[index - 1])) return;
 
@@ -32,14 +23,28 @@ const addSpaceAfter = (index: number, parent: Parent) => {
   parent.children.splice(index + 1, 0, { type: 'text', value: ' ' });
 };
 
-const compatibilityTransfomer = (): Transform => tree => {
-  visit(tree, strongTest, (node, index, parent: Parent) => {
-    trimEmphasis(node);
+const trimEmphasis = (node: Emphasis | Strong, index: number, parent: Parent) => {
+  let trimmed = false;
+
+  visit(node, 'text', child => {
+    const newValue = child.value.trim();
+
+    if (newValue !== child.value) {
+      trimmed = true;
+      child.value = newValue;
+    }
+  });
+
+  if (trimmed) {
     addSpaceBefore(index, parent);
     addSpaceAfter(index, parent);
+  }
 
-    return SKIP;
-  });
+  return node;
+};
+
+const compatibilityTransfomer = (): Transform => tree => {
+  visit(tree, strongTest, trimEmphasis);
 
   visit(tree, 'image', (node: Image, index: number, parent: Parent) => {
     if (phrasing(parent) || !parent.children.every(child => child.type === 'image' || !phrasing(child))) return;