Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: python package renaming #34

Merged
merged 3 commits into from
Aug 17, 2020
Merged

Conversation

emilyskuo
Copy link
Member

@emilyskuo emilyskuo commented Aug 14, 2020

🧰 What's being changed?

Renaming the ReadMe Metrics Python package to readme_metrics, some linting, simplifying imports.

@emilyskuo emilyskuo marked this pull request as ready for review August 14, 2020 23:33
@erunion
Copy link
Member

erunion commented Aug 14, 2020

@emilyskuo Were you able to run the unit tests we've got in here at all? I can never remember the way to run them with unittest.

@emilyskuo
Copy link
Member Author

@emilyskuo Were you able to run the unit tests we've got in here at all? I can never remember the way to run them with unittest.

@erunion the tests don't currently have any assertions in them (they're all commented out). You should be able to run them with python3 MetricsMiddleware.test.py though.

@erunion
Copy link
Member

erunion commented Aug 14, 2020

haha i didn't realize there weren't any assertions

Copy link
Member

@erunion erunion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. @mjcuva you want to merge and build a new release?

@mjcuva
Copy link
Member

mjcuva commented Aug 17, 2020

I don't aestetically love the underscore in readme_metrics. Is that a common thing in python? How do most packages do it?

I don't love ReadMeMetrics either since ReadMe has varied capitolization, so I'm not sure what a better option would be

@emilyskuo
Copy link
Member Author

@mjcuva underscores (snake case) is the typical way to do it in Python! Capitalization (upper camel case??) is typically used with class names.

@mjcuva
Copy link
Member

mjcuva commented Aug 17, 2020

Cool, if it's standard then I'm down for it! I'll build a new release and update the pr in readme. Thank you so much @emilyskuo!!

@mjcuva mjcuva merged commit a7ba6b8 into master Aug 17, 2020
@mjcuva mjcuva deleted the chore/python-package-renaming branch August 17, 2020 18:12
domharrington pushed a commit that referenced this pull request Apr 19, 2022
* chore: rename package to readme_metrics & linting

* chore: fix import statements

* fix: syntax error
djmango pushed a commit to djmango/metrics-sdks that referenced this pull request Sep 19, 2023
Bumps [nock](https://github.com/nock/nock) from 11.7.1 to 11.7.2.
- [Release notes](https://github.com/nock/nock/releases)
- [Changelog](https://github.com/nock/nock/blob/master/CHANGELOG.md)
- [Commits](nock/nock@v11.7.1...v11.7.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@erunion erunion added python Issues related to our Python SDK and removed area:python labels Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Issues related to our Python SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants