Extract HarRequest object
#42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelQ
commented
Aug 17, 2020
Comment on lines
+33
to
+38
| def cookies | ||
| to_hash_array(@env.cookies) | ||
| end | ||
|
|
||
| def http_version | ||
| @env.get_header("HTTP_VERSION") |
There was a problem hiding this comment.
Exposing these public methods feels weird. Perhaps this object is playing two roles: Serializing HAR requests, and modeling an HTTP request. I wonder if maybe I should extract another object here. As a bonus, if that's injected into HarRequest, then I can probably pass in a nice double rather than having to construct an env hash every time 🤔
There was a problem hiding this comment.
I see what you mean, but it doesn't feel too off to me. Extracting another object does sound like it'll clean up testing nicely.
thestrabusiness
approved these changes
Aug 17, 2020
This pulls out all the request logic from `Har` to its own object so it's easier to test variations.
JoelQ
force-pushed
the
jq-extract-request
branch
from
5da60ba
to
f06a355
Compare
djmango
pushed a commit
to djmango/metrics-sdks
that referenced
this pull request
Sep 19, 2023
Bumps [nock](https://github.com/nock/nock) from 12.0.0 to 12.0.1. - [Release notes](https://github.com/nock/nock/releases) - [Changelog](https://github.com/nock/nock/blob/master/CHANGELOG.md) - [Commits](nock/nock@v12.0.0...v12.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
This pulls out all the request logic from
Harto its own object soit's easier to test variations.
🧪 Testing
This is a pure refactor, there are no behavior changes. New automated unit tests were added around some existing behavior.