Add additional option validation #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelQ
approved these changes
Aug 19, 2020
| end | ||
| end | ||
|
|
||
| if options[:buffer_length] && !options[:buffer_length].is_a?(Integer) |
There was a problem hiding this comment.
Since nil isn't an integer, I think you don't need the nil check
There was a problem hiding this comment.
We need the nil check here because buffer_length is optional. It does have a default, but that is set when the RequestQueue class is initialized.
This commit adds some additional validation around options. The new validations verify the types of arguments being passed in.
thestrabusiness
force-pushed
the
am-add-additional-option-validation
branch
from
d90add0
to
8b1a95b
Compare
djmango
pushed a commit
to djmango/metrics-sdks
that referenced
this pull request
Sep 19, 2023
Bumps [nock](https://github.com/nock/nock) from 12.0.2 to 12.0.3. - [Release notes](https://github.com/nock/nock/releases) - [Changelog](https://github.com/nock/nock/blob/master/CHANGELOG.md) - [Commits](nock/nock@v12.0.2...v12.0.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
This commit adds some additional validation around options. The new
validations verify the types of arguments being passed in.
🧪 Testing
Automated tests were added testing each initialization option