-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python): HAR consistency and overall cleanup #540
Conversation
return f"[REDACTED {len(v)}]" | ||
else: | ||
return "[REDACTED]" | ||
def redact_dict(self, mapping: Mapping): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made this a public member because we call it in some unit tests.
finally: | ||
return response |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# connected to the middleware somehow | ||
|
||
|
||
class MockServer: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this because it wasn't being used and we have better server integration tests elsewhere.
@@ -1,6 +1,7 @@ | |||
black==22.3.0 | |||
Django==3.2.14 | |||
Flask==2.0.1 | |||
pylint==2.14.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any concept of devDependencies in pip, or is everything just bundled together?
🧰 Changes
creator
field that we're setting so it's more consistent with the other SDKs.Makefile
in the run dependency installation, linting, and test commands.HAR changes
creator.name
creator.version
creator.comment
[Clang 13.1.6 (clang-1316.0.21.2.5)]
🧬 QA & Testing
All existing tests are/should be still passing.