feat(python): HAR consistency and overall cleanup #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
added
enhancement
erunion
commented
Aug 13, 2022
| return f"[REDACTED {len(v)}]" | ||
| else: | ||
| return "[REDACTED]" | ||
| def redact_dict(self, mapping: Mapping): |
There was a problem hiding this comment.
Made this a public member because we call it in some unit tests.
erunion
commented
Aug 13, 2022
Comment on lines
-49
to
-50
| finally: | ||
| return response |
There was a problem hiding this comment.
erunion
commented
Aug 13, 2022
| # connected to the middleware somehow | ||
|
|
||
|
|
||
| class MockServer: |
There was a problem hiding this comment.
Removed this because it wasn't being used and we have better server integration tests elsewhere.
gratcliff
approved these changes
Aug 13, 2022
| @@ -1,6 +1,7 @@ | |||
| black==22.3.0 | |||
| Django==3.2.14 | |||
| Flask==2.0.1 | |||
| pylint==2.14.5 | |||
There was a problem hiding this comment.
Is there any concept of devDependencies in pip, or is everything just bundled together?
domharrington
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
creatorfield that we're setting so it's more consistent with the other SDKs.Makefilein the run dependency installation, linting, and test commands.HAR changes
creator.namecreator.versioncreator.comment[Clang 13.1.6 (clang-1316.0.21.2.5)]
🧬 QA & Testing
All existing tests are/should be still passing.