Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): HAR consistency #543

Merged
merged 1 commit into from
Aug 16, 2022
Merged

feat(node): HAR consistency #543

merged 1 commit into from
Aug 16, 2022

Conversation

erunion
Copy link
Member

@erunion erunion commented Aug 15, 2022

🚥 Fix RM-5025, #415, #416

🧰 Changes

  • Overhauling our HAR creator field that we're setting so it's more consistent with the other SDKs.

HAR changes

Before After
creator.name readmeio readme-metrics (node)
creator.version 5.2.1 5.2.1
creator.comment mac/v14.19.3 x64-darwin21.3.0/14.19.3

🧬 QA & Testing

All existing tests are/should be still passing.

@erunion erunion added enhancement New feature or request area:node labels Aug 15, 2022
@erunion erunion changed the title feat: making the Node HAR creator object more consistent feat(node): HAR consistency Aug 15, 2022
@erunion erunion merged commit c28999b into main Aug 16, 2022
@erunion erunion deleted the feat/node-har-overhaul branch August 16, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants