Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: automatically retry any failed integration tests #589

Merged
merged 1 commit into from
Sep 7, 2022
Merged

test: automatically retry any failed integration tests #589

merged 1 commit into from
Sep 7, 2022

Conversation

erunion
Copy link
Member

@erunion erunion commented Sep 6, 2022

🧰 Changes

We still have the occasionally flaky test in CI so this might help as they most always run fine on the next go around.

https://mochajs.org/#retry-tests

@erunion erunion marked this pull request as ready for review September 6, 2022 23:31
domharrington
domharrington approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@domharrington domharrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldnt be opposed to setting this higher than 2, but this'll do for now.

@domharrington domharrington merged commit 4d1f6b2 into main Sep 7, 2022
@domharrington domharrington deleted the test/retry-flaky-tests branch September 7, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domharrington domharrington domharrington approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erunion @domharrington