Don't send request on OPTIONS #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelQ
approved these changes
Aug 25, 2020
This commit updates the behavior of the middleware to skip processing OPTIONS requests.
thestrabusiness
force-pushed
the
am-filter-out-options-request
branch
from
ec82085
to
dfd6f50
Compare
djmango
pushed a commit
to djmango/metrics-sdks
that referenced
this pull request
Sep 19, 2023
…io#68) * fix: use postData.text for JSON to handle nested body content After seeing issues with nested object content where param values were objects when they should only be strings (and talking with @erunion and @domharrington), I opted to update our request processing so we're using postData.text to store JSON request bodies, instead of postData.params. This is more compliant with HAR and it allows us to store nested request body content properly. * fix another test * Update lib/process-request.js Co-Authored-By: Jon Ursenbach <erunion@users.noreply.github.com> Co-authored-by: Jon Ursenbach <erunion@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
This commit updates the behavior of the middleware to skip processing
OPTIONS requests.
🧪 Testing
A new test was added to the test suite to ensure a request is not made to the ReadMe API. This was also tested manually using a rack application and this curl command:
curl -i -X OPTIONS localhost:9292/apiNo corresponding item shows up in the dashboard.