Provide default values when Content-Length is absent #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on the HAR spec, I think we want to put -1 if we don't know the length rather than 0
|
JoelQ
reviewed
Aug 27, 2020
thestrabusiness
force-pushed
the
am-default-content-length
branch
from
952c42e
to
de28038
Compare
JoelQ
reviewed
Aug 27, 2020
thestrabusiness
force-pushed
the
am-default-content-length
branch
from
119342c
to
8cbcadf
Compare
JoelQ
approved these changes
Aug 27, 2020
| expect(response.body).to eq "" | ||
| end | ||
|
|
||
| it "returns an empty string when the body is an array of string" do |
There was a problem hiding this comment.
The doc string is wrong here, this isn't an empty string
| response = HttpResponse.from_parts( | ||
| 204, | ||
| {"Content-Length" => 53}, | ||
| nil |
There was a problem hiding this comment.
Can we put an actual body here so the test proves that it's the 204 status rather than the nil causing the 0?
The Content-Length header is not included by default starting in Rails 5. This commit adds a default -1 value for the `Har::ResponseSerializer` for values that rely on the Content-Length header when it is absent. The instructions are also updated to mention the `Rack::ContentLength` middleware users can add to their application if they'd like to see that value in their ReadMe requests.
thestrabusiness
force-pushed
the
am-default-content-length
branch
from
8cbcadf
to
f8978aa
Compare
djmango
pushed a commit
to djmango/metrics-sdks
that referenced
this pull request
Sep 19, 2023
…meio#70) Bumps [@readme/eslint-config](https://github.com/readmeio/eslint-config) from 2.0.4 to 2.0.6. - [Release notes](https://github.com/readmeio/eslint-config/releases) - [Changelog](https://github.com/readmeio/eslint-config/blob/master/CHANGELOG.md) - [Commits](readmeio/standards@2.0.4...2.0.6) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
The Content-Length header is not included by default starting in Rails
5. This commit adds some new functionality to the HttpResponse class
so that we can calculate the content length if the header is not present.
Commit that removes the middleware: rails/rails@5690358
🧪 Testing
Automated tests were added to cover this new behavior.