Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring CSS styles from Read the Docs addons into ad client #193

Open
humitos opened this issue May 21, 2024 · 3 comments
Open

Bring CSS styles from Read the Docs addons into ad client #193

humitos opened this issue May 21, 2024 · 3 comments

Comments

@humitos
Copy link
Member

humitos commented May 21, 2024

Read the Docs publisher define specific CSS rules to style the ad in a different way. We talked about moving these styles into the ad client itself and rely on light / dark styles only instead of theme based like ethical-alabaster.

Reference:

@ericholscher
Copy link
Member

I put this in Q2, because it's a nice refactor while we're doing this work.

@davidfischer
Copy link
Contributor

Are we thinking of bringing styles from RTD to the ad client? Or are we thinking about having RTD just use the built-in styles/ad types rather than doing something custom?

@humitos
Copy link
Member Author

humitos commented May 24, 2024

Yeah, I think we are talking about the later: "use dark/light styles from the EA client in Read the Docs publisher".

However, I think we may still want some extra CSS classes in for some themes/doctools. I'm mentioning this because I found, for example, Pelican that renders in a weird way:

Peek 2024-05-24 17-10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants