Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors: how to handle porting contextualize 404 error pages #11486

Closed
agjohnson opened this issue Jul 20, 2024 · 1 comment
Closed

Errors: how to handle porting contextualize 404 error pages #11486

agjohnson opened this issue Jul 20, 2024 · 1 comment
Labels
Accepted Accepted issue on our roadmap Needed: design decision A core team decision is required

Comments

@agjohnson
Copy link
Contributor

While looking into porting the proxito error pages, I'm finding the complexity in these templates could be reduced a good deal and perhaps this is even a case for moving some of the functionality into addons instead.

The current error pages do the following:

Deciding how to port this over though, it feels like what we want out of error pages is:

  • A search input that triggers the addons embedded, in-doc search modal, not the dashboard search
  • Content that focuses on readers users, not maintainers. Remove tips on custom domain configuration and adding redirects.
  • Should we be surfacing the reason for the 404 error through addons too? This would give custom error pages a chance to use the same descriptive prose. Is this important?

I'm feeling like it's not clear what is important to port over now that we are surfacing features through addons.

@agjohnson
Copy link
Contributor Author

I addressed most of this in readthedocs/ext-theme#304

I'll bring up some Addons/flyout integration on search in that repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Needed: design decision A core team decision is required
Projects
Archived in project
Development

No branches or pull requests

1 participant