You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think it is a good feature when a Github repository has new head, the project in the RTD got updated immediately. The problem is that if I commit several times in a short interval, the RTD would lock this project for 5 minutes.
This is a situation encountered by the GGeditor. GGeditor is a Google Docs add-on. It converts Google Docs document into reStructuredText and commits it to a Github repository. Due to the limitation of the API which is utilized for committing , if a document contains 10 images, the head of repository would be updated for 11 times in a short interval.
Expected Result
My suggestion is to have an option in the conf.py which would postpone the trigger of rebuilding for a while when a new head of repository is detected. For example, 60 seconds, and the timer would be reset if there is another new head been detected within 60 seconds. It would make sure rebuilding is been triggered only once after the last image-uploading has completed.
With this option, the RTD would also save resources of rebuilding.
More than a user option I think this should be an automatic protection from Read the Docs to avoid people triggering multiple (more than X) builds in the same minute.
just skipping the trigger of the build could be confusing for the user
we could check the queue to see if there is already a build queued, remove it from the queue, and add the new one with the new commit (kind of complicated)
create a Build object but do not trigger it and mark it as FAILED with the correct error message (it will produce to the first build triggered to build and the last --which I think it's the most important-- to not build)
Details
I think it is a good feature when a Github repository has new head, the project in the RTD got updated immediately. The problem is that if I commit several times in a short interval, the RTD would lock this project for 5 minutes.
This is a situation encountered by the GGeditor. GGeditor is a Google Docs add-on. It converts Google Docs document into reStructuredText and commits it to a Github repository. Due to the limitation of the API which is utilized for committing , if a document contains 10 images, the head of repository would be updated for 11 times in a short interval.
Expected Result
My suggestion is to have an option in the conf.py which would postpone the trigger of rebuilding for a while when a new head of repository is detected. For example, 60 seconds, and the timer would be reset if there is another new head been detected within 60 seconds. It would make sure rebuilding is been triggered only once after the last image-uploading has completed.
With this option, the RTD would also save resources of rebuilding.
References
GGeditor manual in the RTD
GGeditor add-on in the Google Add-on Store
The text was updated successfully, but these errors were encountered: