Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing build failed message (time out and memory consumption) #4468

Closed
stsewd opened this issue Aug 3, 2018 · 3 comments · Fixed by #8815
Closed

Confusing build failed message (time out and memory consumption) #4468

stsewd opened this issue Aug 3, 2018 · 3 comments · Fixed by #8815
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code

Comments

@stsewd
Copy link
Member

stsewd commented Aug 3, 2018

Recently I have seen some reports of build failure like #4443, where the failed build display two different messages as the failure reason.

Here you can see an example https://readthedocs.org/projects/oapackage/builds/7559891/. The error message is Build exited due to time out, but the last command that was executed failed with Command killed due to excessive memory consumption.

@agjohnson
Copy link
Contributor

This is because the best guess we have when docker kills something is looking for the 137 exit code, which usually indicates that memory was an issue. Unfortunately, we don't have a better way to determine this, so we're likely to get false positives. What happened here is project timed out, killing the process inside docker, reporting the exit code as 137.

Not sure if there is a lot we can do here, or if there is, if there is much benefit.

@agjohnson agjohnson added the Improvement Minor improvement to code label Sep 17, 2018
@agjohnson agjohnson added this to the Build error reporting milestone Sep 17, 2018
@stsewd
Copy link
Member Author

stsewd commented Sep 18, 2018

Not sure if there is a lot we can do here, or if there is, if there is much benefit.

mmm, I haven't see the code, but we could try to get the error from the latest command (I think we already inspect the output), so both error messages match. Right now is confusing for the users, and gives a wrong hint about the problem.

@stale
Copy link

stale bot commented Jan 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Jan 10, 2019
@stsewd stsewd added Accepted Accepted issue on our roadmap and removed Status: stale Issue will be considered inactive soon labels Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants